Drop Node 6 support. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix linting to avoid CI breaking
kibertoad
commented
Apr 14, 2020
| @@ -54,8 +55,7 @@ | |||
| "decimal.js": "^10.2.0", | |||
| "js-yaml": "^3.13.1", | |||
| "json-schema-deref-sync": "^0.13.0", | |||
| "object.values": "^1.1.1", | |||
| "swagger-parser": "^6.0.5" | |||
| "swagger-parser": "^9.0.1" | |||
There was a problem hiding this comment.
This is an important benefit of bumping Node version, up-to-date swagger-parser no longer brings in core-js as a transitive dependency, which should help solve PayU/openapi-validator-middleware#116
There was a problem hiding this comment.
@kibertoad , if we're going to release a breaking change, i'd like to also handle this together #39
There was a problem hiding this comment.
Sure, I'll work on that, but probably they can be merged separately.
|
@kobik Do you think that this change makes sense? |
yes, i think you have a point here. too bad they still haven 't implemented sync file loading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes linting to avoid CI breaking.
Considering that even Node 8 is already deprecated, it might make sense to drop support for Node 6, remove shims, upgrade to swagger-parser version that also got rid of shims, and bump major version.
Related to PayU/openapi-validator-middleware#116